Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This GIF File kills App #50

Closed
reipielr opened this issue Apr 9, 2014 · 4 comments
Closed

This GIF File kills App #50

reipielr opened this issue Apr 9, 2014 · 4 comments
Assignees
Labels

Comments

@reipielr
Copy link

reipielr commented Apr 9, 2014

img_bad

T^T

@reipielr
Copy link
Author

reipielr commented Apr 9, 2014

omg i just testing 'writing issue' is working well, but i can't find delete button.
anyway, point is gif that i uploaded makes crash on 1.0.7
but on 1.0.4, that works well!
And i'm sorry for my bad english

@koral-- koral-- added the bug label Apr 9, 2014
@koral-- koral-- self-assigned this Apr 9, 2014
@koral--
Copy link
Owner

koral-- commented Apr 9, 2014

If something is not working on the latest version then it's a bug. I will check it.

@reipielr
Copy link
Author

I debugged and found stack
open -> readExtensions -> setupBackupBmp -> getColorFromTable

char colIdx = idx >= cmap->ColorCount ? 0 : idx;
cmap is NULL (ColorMapObject)

so i wonder if i add this code, is there will be any side-effact?
if (cmap == NULL) {
cmap = getDefColorMap();
}

koral-- added a commit that referenced this issue Apr 10, 2014
@koral--
Copy link
Owner

koral-- commented Apr 10, 2014

Color map in that place should never be NULL since it should be checked and optionally set to default while opening a GIF. Bug existed in open().

@koral-- koral-- closed this as completed Apr 10, 2014
@niplus niplus mentioned this issue Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants