Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Boyer-Moore string deletion algorithm as a fix for issue #286 #662

Closed
wants to merge 1 commit into from

Conversation

aryanVanaik
Copy link

@aryanVanaik aryanVanaik commented Oct 27, 2023

Mandatory checks

  • [x ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • [x ] Tests created for changes (if applicable)
  • [ x] Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • [x ] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [ x] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Closes #286

Copy link
Owner

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems to fix the issue, but way too complicated. Java has string replacement functionality. JabRef has cleanup formatters. Look around in the code what they do.

Never use [], Java has better data structures.

Tests are not consistent with other tests. The test will not fail if nothing is returned. The test should work when being offline.

@koppor
Copy link
Owner

koppor commented Nov 14, 2023

Closing this issue due to inactivity 💤

Please ping us if you intend to resume work on this one.

@koppor koppor closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cleanup for em dash
3 participants