Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename to delete should be shown completely #534

Closed
koppor opened this issue Nov 3, 2021 · 2 comments · Fixed by JabRef/jabref#9284
Closed

Filename to delete should be shown completely #534

koppor opened this issue Nov 3, 2021 · 2 comments · Fixed by JabRef/jabref#9284

Comments

@koppor
Copy link
Owner

koppor commented Nov 3, 2021

When deleting a file, the file path is sometimes too long to fit in the title of the dialog.

grafik

Proposal: Show the filename also in the dialog text

@Racheal7
Copy link

Hi Koppor, I am really interested in this issue and I'd like to contribute. Could you please assign this issue to me? Thank you very much.

@Racheal7
Copy link

Hi Oliver,

I have looked into this issue and come up with several solutions to improve the UI.

  1. Delete the file path in the dialog title and replace it with "Delete File". Add the full file path in the text.

Add file name to text

  1. In the dialog title, replace the full file path with only the file name, and add the full file path in the text.

Add only file name in title

  1. Just like you suggested in the description, we can keep the file path in the title and add it to the text.

Only add file path in text

Personally, I prefer the second solution as it's neater, but I'd love to know what you think.

Racheal7 added a commit to Racheal7/jabref that referenced this issue Oct 22, 2022
This pull request fixes the issue koppor#534.

My solution is that instead of absolute file path, only the file name is showed in the dialog title. The file's absolute path is added in the dialog text.
Racheal7 added a commit to Racheal7/jabref that referenced this issue Oct 23, 2022
This pull request fixes the issue koppor#534.

My solution is that instead of absolute file path, only the file name is showed in the dialog title. The file's absolute path is added in the dialog text.
@ThiloteE ThiloteE moved this from Free to take to In Progress in Good First Issues Oct 23, 2022
tobiasdiez pushed a commit to JabRef/jabref that referenced this issue Oct 25, 2022
Instead of absolute file path, only the file name is showed in the dialog title. The file's absolute path is added in the dialog text.

Fixes koppor#534.
Repository owner moved this from In Progress to Done in Good First Issues Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants