Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect violations in forwardRef #24

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

adbutterfield
Copy link
Contributor

Adds detection of violations inside React.forwardRef.
Closes #23.

@adbutterfield
Copy link
Contributor Author

adbutterfield commented Aug 24, 2023

Ah! There's a problem.
I tried to install it locally, and now it ONLY detects violations inside forwardRef, and not normal functional components (even though all the tests pass...).

Actually, I think maybe I found another case where the violations aren't being detected.

@adbutterfield adbutterfield changed the title Add support for forward ref Detect violations in forwardRef Aug 24, 2023
@adbutterfield
Copy link
Contributor Author

Hi @kopiro, it would be cool if you had some time to check this any my other PR.
Thanks!

@adbutterfield
Copy link
Contributor Author

Hi @kopiro, just wanted to ping you again. If you would like help maintaining this package, I would be interested to help support!

@kopiro
Copy link
Owner

kopiro commented Nov 13, 2023

I'm so, so sorry! I'll merge it now and bump the version

@kopiro kopiro merged commit 0c1bcee into kopiro:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect violations when using React.forwardRef
2 participants