-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
Looks good. Any reason not to update rules-go to a newer version that recognizes the newer go version? |
I guess not in |
Ah - that makes sense. Let's stick with what you've got here for now, for consistency then. /approve |
Fix for the deprecation should be in #362 |
I merged #362 - do you want to rebase and then I can cut a release? Or should we leave this one till the next etcd-manager release? |
Let's leave for next release please. Until then maybe we can do it in a nicer way, similar to kubernetes/kops#10240. |
@justinsb this should make things identical to kOps now. |
94ce30f
to
f55d1a6
Compare
6235e5a
to
fd5ab61
Compare
159f29b
to
3881fa3
Compare
908fee2
to
9c95d26
Compare
1c288d0
to
7c8f960
Compare
@justinsb I think tis is now ready to go. |
@hakman do you think we should try to do this before kops 1.19.0? |
@justinsb I think it may be safer to merge this after the new release for 1.19 and create a new release that we will use only on master for now. We will include it later in 1.19.1 if no issues are discovered. |
Kops 1.19 is built with 1.15.4 for reference |
Addressing that with kubernetes/kops#10603. |
And... success. Looks like both PRs passed the tests. |
... to match kOps.