Use env vars to customize backup retention #322
Conversation
| // ParseHumanDuration parses a go-style duration string, but | ||
| // recognizes additional suffixes: d means "day" and is interpreted as | ||
| // 24 hours; y means "year" and is interpreted as 365 days. | ||
| func ParseHumanDuration(s string) (time.Duration, error) { |
There was a problem hiding this comment.
This was shamelessly copied from certs.go. I couldn't find some good common utils place for it.
Line 32 in 84bd908
|
Why would we use env vars instead of flags or a config file? |
No special reason, just followed the approach from f4b782c. At the moment Kops has the option of setting env vars to control etcd-manager. |
|
I wouldn't mind also adding flags, but let's get this going as-is. If we start specifying these values directly in the etcd struct in kops, we'll have to deal with the fact that they can be specified in both env and directly, but we have to deal with that anyway for the metrics-url. (cc @granular-ryanbonham ) Thanks for this @hakman ! /approve |
|
Thank you @hakman, great job! |
At the moment backup retention is hardcoded.
Hourly backups are kept for 7 days and daily backups are kept for 1 year.
Env vars could be used to customise backup retention:
Fixes #225
Fixes #308