This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Ensure that FindMountedVolume returns ("", nil) when not found #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually @zetaab would you mind looking at this ... I think the retry loop might return an error when it times out, which isn't really what we want. The problem is that it isn't always possible to cancel a disk attachment (e.g. on AWS) so our best bet is to just keep waiting. I don't know if OpenStack has a better option that actually works! |
This helps the retry logic work correctly.
justinsb
force-pushed
the
find_mounted_volume_return
branch
from
6f605de to
0f764ee
Compare
zetaab
approved these changes
Dec 7, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps the retry logic work correctly.