This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Initial Alicloud volume/discovery implementation #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittopaz
commented
Nov 13, 2019
This was referenced Nov 27, 2019
zetaab
reviewed
Nov 27, 2019
|
In order to get this PR merged, the follow tasks need to be done by sequence:
|
|
@justinsb could you check this PR that we could get alicloud support forward |
justinsb
reviewed
Dec 9, 2019
|
In general this looks right. I don't know exactly which kops version you want, but I'm updating it in #278, and am also updating the version of kubernetes that we are using in kops (kubernetes/kops#8055) |
|
Thank you for reviewing this, @justinsb, the related changes kubernetes/kops#8025 were merged into master branch only a few days ago, thus I think we need to use latest master branch as dependency in etcd-manager. |
bittopaz
changed the title
Merged
bittopaz
changed the title
|
Removed WIP from title, this is ready to merge. |
|
Thanks @bittopaz - this looks great! /approve |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of kubernetes/kops#4127
This PR is NOT able to be merged due to the replaced kops module.
Please find this commit for what needs to be changed in kops.
I also opened a issue asking for upgrading kops dependency: #268