This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Better etcd-version handling #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We move etcd version handling to its own package, and we are now more tolerant about reading from patch versions that we don't have (we adopt the same-or-next minor rule that etcd uses). Also on etcd cluster adoption we bump it to the next supported version so that we can come up even if the user was previously running an unsupported version.
justinsb
force-pushed
the
better_etcd_version_handling
branch
from
84d84e6 to
0708fe6
Compare
|
Cross checked against etcd upgrade docs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move etcd version handling to its own package, and we are now more
tolerant about reading from patch versions that we don't have (we
adopt the same-or-next minor rule that etcd uses). Also on etcd
cluster adoption we bump it to the next supported version so that we
can come up even if the user was previously running an unsupported
version.