This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Fix unexpected etcd image error if docker pulls images over proxy #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrmann
force-pushed
the
patch-1
branch
2 times, most recently
from
3345578 to
a610152
Compare
|
tests run fine locally. Seems like the travis builds just have time outs |
|
Thanks @kirrmann - and I believe we've fixed those timeouts on head (but travis does not rebase before testing). I tweaked the logic so that it would pick up the version even in the "3 component" case, but thanks for reporting & fixing! /approve |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use etcd-manager in kops which is setup to use a proxy to pull docker images.
But starting etcd-manager would always abort with
error initializing etcd server: unexpected etcd image \“nexus.internal:8500/etcd:2.2.1\“The two colons do incorrectly let a check fail to verify the specified name of the etcd docker image.