Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLP Encode Header - Off by one error #9

Open
TbLtzk opened this issue Jul 13, 2018 · 1 comment
Open

RLP Encode Header - Off by one error #9

TbLtzk opened this issue Jul 13, 2018 · 1 comment

Comments

@TbLtzk
Copy link

TbLtzk commented Jul 13, 2018

The RLP specification has one path for encoding 0-55 bytes and another path for encoding longer byte arrays.

This should be programmed as if length < 56 or if length <= 55. There are two places with length < 55
@TbLtzk
Copy link
Author

TbLtzk commented Jul 13, 2018

personally I prefer <56 but to stay consistent with other places I'd go for <=55

TbLtzk pushed a commit to TbLtzk/web3-arduino that referenced this issue Jul 13, 2018
fix kopanitsa#9 off-by-one
c03b84d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TbLtzk