✨ Remove deprecated go get from Makefile #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 54.34% 54.34%
=======================================
Files 77 77
Lines 7277 7277
=======================================
Hits 3955 3955
Misses 2972 2972
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Jason Liu <[email protected]>
saintube
reviewed
May 4, 2022
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Liu [email protected]
Ⅰ. Describe what this PR does
In Go 1.18, using go get to install go binaries is no longer supported, which breaks the go-get-tool step in the Makefile.
This was originally taken from Kubebuilder, and it looks like the new recommended approach is to simply use go install: kubernetes-sigs/kubebuilder#2486
This PR fixes all build dependencies to use the new method.