Fix bug with decimal places in range option #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the G0 descriptor the compiler checks the best way to output the number
Closed
kookma
reviewed
Sep 6, 2020
kookma
reviewed
Sep 6, 2020
| write ( this%file_unit, '(" ")' ) | ||
| write ( this%file_unit, '("# options")' ) | ||
| write ( this%file_unit, '(a)' ) this%txtoptions | ||
| write ( this%file_unit, '(a)' ) |
There was a problem hiding this comment.
What is the reason for modifying this section?
There was a problem hiding this comment.
Consistency: why some write statements have the unit= and fmt= while others don't?
kookma
reviewed
Sep 6, 2020
| case ('loglog') | ||
| write ( this%file_unit, '(a)' ) 'set logscale xy' | ||
| write ( this%file_unit, '("set logscale xy")' ) | ||
| case default !for no setting | ||
| !pass | ||
| end select |
There was a problem hiding this comment.
Use ' instead " for consistency
Keep inline comments
The reason you deleted fmt=?
There was a problem hiding this comment.
Same reason as before.
|
Thanks @14NGiestas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the G0 descriptor the compiler checks the best way to output the number.
I took the liberty and made some changes in the write statements to make them look the same.