🐛 Use standard filters for languages in the Set Targets step (#2045) #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![konveyor-ci-bot[bot]](https://avatars.githubusercontent.com/in/819470?s=60&v=4){kind=small}
Before, in the Set Targets step, if the languages were not pre-selected
automatically then no cards were visible. In order to see target cards
user had to select at least one language.
After this fix, all target cards will be visible.
Additional changes:
1. wait (display a spinner) until all necessary queries finished before
displaying Set Targets step
2. improve error handling
1. display error when targets could not be loaded
2. silently ignore failed optional queries and continue without extra
featues
3. extract data fetching into one hook
Resolves: #2009
Resolves: https://issues.redhat.com/browse/MTA-3515
---------
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Co-authored-by: Scott J Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
konveyor-ci-bot
bot
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
sjd78
approved these changes
Aug 20, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, in the Set Targets step, if the languages were not pre-selected
automatically then no cards were visible. In order to see target cards
user had to select at least one language.
After this fix, all target cards will be visible.
Additional changes:
displaying Set Targets step
featues
Resolves: #2009
Resolves: https://issues.redhat.com/browse/MTA-3515
Signed-off-by: Radoslaw Szwajkowski [email protected]
Signed-off-by: Scott J Dickerson [email protected]
Co-authored-by: Scott J Dickerson [email protected]
Signed-off-by: Cherry Picker [email protected]