🐛 [backport release-0.5] Analysis - Update the TaskGroup to id selected rulesets (#2034) #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![konveyor-ci-bot[bot]](https://avatars.githubusercontent.com/in/819470?s=60&v=4){kind=small}
Supports: https://issues.redhat.com/browse/MTA-3330 The way custom targets are handled by the analysis wizard has been updated. There are no visual changes. At analysis start time, a `Taskgroup` is submitted containing all of the user's choices. To better support custom targets, the `ruleSet` of any selected custom targets will no be submitted as part of the `Taskgroup.TaskData.rules`. Identifying the `ruleSet` will allow the custom target's rules to be enabled in analysis. In support of this change: - The wizard's form data now stores a `Target[]` instead of a `number[]` to make working with the selected targets more convenient across the wizard components. - Any code working with just the `targetId` has been updated to use the full `Target` object - The handlers for changes to the target labels on the wizard's options step better handle mapping the selected label changes to target card selection --------- Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
konveyor-ci-bot
bot
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
sjd78
changed the title
sjd78
approved these changes
Aug 2, 2024
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport-of: #2034
Supports: https://issues.redhat.com/browse/MTA-3330
The way custom targets are handled by the analysis wizard has been
updated. There are no visual changes.
At analysis start time, a
Taskgroupis submitted containing all of theuser's choices. To better support custom targets, the
ruleSetof anyselected custom targets will no be submitted as part of the
Taskgroup.TaskData.rules. Identifying theruleSetwill allow thecustom target's rules to be enabled in analysis.
In support of this change:
Target[]instead of anumber[]to make working with the selected targets more convenient across the
wizard components.
targetIdhas been updated to use thefull
Targetobjectstep better handle mapping the selected label changes to target card
selection
Signed-off-by: Scott J Dickerson [email protected]
Signed-off-by: Cherry Picker [email protected]