✨ Add custom matchers to client side filters #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
+ Coverage 39.20% 42.10% +2.90%
==========================================
Files 146 163 +17
Lines 4857 5235 +378
Branches 1164 1309 +145
==========================================
+ Hits 1904 2204 +300
- Misses 2939 3015 +76
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Before this PR, all values were matched in the same way: 1. value needs to be string or have string representation via getItemValue 2. positive match is returned if (lowercased) value contains (lowercased) filter value. After this PR, a custom algorithm can be provided using "matcher" property. Direct motivation was DateRange filter which stores filter values as ISO 8601 time intervals i.e. "2024-04-01/2024-05-01". Positive match (value is in the range) requires parsing to date objects. Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals Signed-off-by: Radoslaw Szwajkowski <[email protected]>
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, all values were matched in the same way:
getItemValue
(lowercased) filter value.
After this PR, a custom algorithm can be provided using "matcher"
property. Direct motivation is DateRange filter which stores filter
values as ISO 8601 time intervals i.e. "2024-04-01/2024-05-01".
Positive match (value is in the range) requires parsing to date objects.
Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals
Reference-Url: #1913