Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate from k8s.gcr.io to registry.k8s.io #7

Closed
wants to merge 1 commit into from

Conversation

CIPHERTron
Copy link

This fix is a part of an umbrella issue kubernetes/k8s.io#4780

@ahmedwaleedmalik
Copy link

@PhilipCattanach can you PTAL?

@PhilipCattanach
Copy link
Contributor

@carlosthe19916 - Could you review this PR please?

@carlosthe19916
Copy link
Member

@CIPHERTron @ahmedwaleedmalik @PhilipCattanach I don't see anything wrong in this PR since it only changes the name of the registry from which the container image is being pulled. However, the file Dockerfile.init has been fully rewritten in the main branch. Is this PR still valid given the fact that the file Dockerfile.init has been modified very recently?

@ahmedwaleedmalik
Copy link

@carlosthe19916 @CIPHERTron I think we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants