147 deprecated exceptions - WIP #202
Conversation
Signed-off-by: Daniel Vaseekaran <[email protected]>
Signed-off-by: dvaseekara <[email protected]>
| @@ -90,3 +90,39 @@ | |||
| url: https://eclipse.dev/eclipselink/downloads/previous_releases.php | |||
| - title: 'Spring 6.0 migration guide' | |||
| url: https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-6.0-Release-Notes#removed-apis | |||
|
|
|||
| - ruleID: spring-framework-5.x-to-6.0-data-access-00030 | |||
| category: mandatory | |||
There was a problem hiding this comment.
This would be an optional issue instead of a mandatory one, since these members are only deprecated, not removed, so there is no real need to change them yet.
| effort: 1 | ||
| labels: | ||
| - konveyor.io/source=springboot2 | ||
| - konveyor.io/target=springboot3 |
There was a problem hiding this comment.
The targets would be:
labels:
- konveyor.io/source=spring5
- konveyor.io/target=spring6+We'll have to add the spring boot targets eventually, but for now lets just use these.
| - konveyor.io/source=springboot2 | ||
| - konveyor.io/target=springboot3 | ||
| tags: | ||
| - springframework.dao |
There was a problem hiding this comment.
Here, the correct field is tag:, and it would look something like this:
tag:
- Spring FrameworkYou can take a look at other rules to see how it's usually done
| java.referenced: | ||
| pattern: org.springframework.dao.DeadlockLoserDataAccessException | ||
| location: IMPORT | ||
| description: DeadlockLoserDataAccessException is depracated in favor of CannotAcquireLockException |
There was a problem hiding this comment.
Typo in "deprecated", here and in the other places.
| message: "DeadlockLoserDataAccessException is depracated in favor of CannotAcquireLockException" | ||
| links: | ||
| - title: 'org.springframework.http.HttpMethod Documentation' | ||
| url: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/HttpMethod.html |
There was a problem hiding this comment.
This documentation doesn't correspond with the issue
| - title: 'org.springframework.http.HttpMethod Documentation' | ||
| url: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/HttpMethod.html | ||
|
|
||
| - ruleID: spring-framework-5.x-to-6.0-data-access-00040 |
There was a problem hiding this comment.
The same comments from the other rule apply here
| @@ -0,0 +1,51 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
There was a problem hiding this comment.
Lets use the existing project in data/data-access - basically move this project up one step and merge the poms. We just need to make sure that all the tests for data-access still pass.
No description provided.