generated from konveyor/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Missing description in technology-usage rules #159
Open
aufi
wants to merge
5
commits into
konveyor:main
Choose a base branch
from
aufi:missing-tech-description
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on failQA of ticket bellow when testing similar issue with other application, a script checking description of rules was added and it provides information that on technology-usage rules ("insight"). Related to: https://issues.redhat.com/browse/MTA-3212 Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
|
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
|
IIRC these sort of rules don't have description because they are tagging rules. @pranavgaikwad am I right? |
pranavgaikwad
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though these are tagging rules, I think it makes sense to have this one word description because we have a new tab now for tags that displays information in detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on failQA of ticket below when testing similar issue with other application, a script checking description of rules was added and it provides information on technology-usage rules ("insight") rules description.
Status before this PR was that from 772 discovery rules, 408 had empty description. Added descriptions using a script (and few manually). The script might be useful next time, was kept in
hack
directory.Related to: https://issues.redhat.com/browse/MTA-3212