Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 adding release flag #96

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Oct 30, 2024

Updating the right release action this time.

  • removed unused release workflow

Signed-off-by: Savitha Raghunathan <[email protected]>
Signed-off-by: Savitha Raghunathan <[email protected]>
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go ahead and make this a new action we can reuse.

create-release/action.yml Outdated Show resolved Hide resolved
Signed-off-by: Savitha Raghunathan <[email protected]>
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan
Copy link
Member Author

@djzager I have pulled the changelog out and reused it in konveyor/editor-extensions#86. I will create a separate PR to include changelog gen into konveyor create release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't be afraid to replace the existing changelog stuff in here with the new action.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integrated the workflow. ptal. I had to accommodate two different ways of specifying secrets.

Signed-off-by: Savitha Raghunathan <[email protected]>
Signed-off-by: Savitha Raghunathan <[email protected]>
@djzager djzager merged commit f7bc02e into konveyor:main Nov 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants