Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devrel 1090/cli improvements #16

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Devrel 1090/cli improvements #16

merged 11 commits into from
Jan 15, 2024

Conversation

JiriLojda
Copy link
Member

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@JiriLojda JiriLojda requested a review from a team as a code owner January 10, 2024 16:28
Copy link
Member

@pokornyd pokornyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworded some messages and fixed typos, otherwise looking good. some tests would be lovely tho :)

@JiriLojda
Copy link
Member Author

Great, thanks, tests will come in later.

@JiriLojda JiriLojda merged commit e0d235b into main Jan 15, 2024
1 check passed
@JiriLojda JiriLojda deleted the DEVREL-1090/cli_improve branch January 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants