Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devrel 1075/add spaces import #13

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Devrel 1075/add spaces import #13

merged 2 commits into from
Jan 8, 2024

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral requested review from JiriLojda and a team as code owners January 3, 2024 11:17
@IvanKiral IvanKiral force-pushed the DEVREL-1075/add_spaces_import branch from 8162221 to 4322ffe Compare January 3, 2024 11:24
@JiriLojda JiriLojda force-pushed the DEVREL-1075/add_spaces_import branch from 4322ffe to e16f4ba Compare January 8, 2024 11:41
@JiriLojda JiriLojda force-pushed the DEVREL-1075/add_spaces_import branch from e16f4ba to 98dffce Compare January 8, 2024 12:10
JiriLojda
JiriLojda approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rebased and fixed conflicts. It would be nice to have a flag for importing also web spotlight roots or a general flag like --with-web-spotlight or something like that. But lets not delay merging this PR with this.

@JiriLojda JiriLojda merged commit ce919bd into main Jan 8, 2024
1 check passed
@JiriLojda JiriLojda deleted the DEVREL-1075/add_spaces_import branch January 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriLojda JiriLojda JiriLojda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanKiral @JiriLojda