Devrel 1067 import assets and folders #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This builds on the taxonomies branch and should be merged after it. |
JiriLojda
force-pushed
the
DEVREL-1067_import_assets_and_folders
branch
from
f6698f6
to
17cf20d
Compare
IvanKiral
requested changes
Dec 8, 2023
|
|
||
| export const assetsExportEntity: EntityDefinition<ReadonlyArray<AssetContracts.IAssetModelContract>> = { | ||
| const assetsBinariesFolderName = "assets"; | ||
| const createFilePrefix = (asset: AssetContracts.IAssetModelContract) => `${asset.id}-`; |
There was a problem hiding this comment.
why this is not createFileName and do the whole name? :D
There was a problem hiding this comment.
Because I thought that I would need the length of the prefix to strip it when importing, but it turns out I can get the name from the asset entity itself so this is not needed and therefore, I can make it createFileName instead. 😄
JiriLojda
force-pushed
the
DEVREL-1067_import_assets_and_folders
branch
from
8c7d008
to
63a830d
Compare
IvanKiral
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?