Allow to redefine api_url #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 5, 2016
| described_class.api_url = nil | ||
| expect(described_class.instance.http_client.params).to eq(get_client_new_params) | ||
| described_class.api_url = 'http://foo.bar:1337' | ||
| expect(described_class.instance.http_client.params).to eq(get_client_new_params) |
houndci-bot
reviewed
Dec 5, 2016
|
|
||
| it 'can edit api_url' do | ||
| described_class.api_url = nil | ||
| expect(described_class.instance.http_client.params).to eq(get_client_new_params) |
houndci-bot
reviewed
Dec 5, 2016
| path: uri.path, | ||
| port: uri.port, | ||
| query: uri.query, | ||
| scheme: uri.scheme, |
There was a problem hiding this comment.
Avoid comma after the last item of a hash.
houndci-bot
reviewed
Dec 5, 2016
| @@ -23,7 +24,23 @@ | |||
| end | |||
|
|
|||
| describe '#api_url' do | |||
|
|
|||
| def get_client_new_params | |||
There was a problem hiding this comment.
Method has too many lines. [11/10]
Do not prefix reader method names with get_.
houndci-bot
reviewed
Dec 5, 2016
| @@ -23,7 +24,23 @@ | |||
| end | |||
|
|
|||
| describe '#api_url' do | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at block body beginning.
houndci-bot
reviewed
Dec 5, 2016
| end | ||
|
|
||
| def self.api_url=(url) | ||
| self.instance.api_url = url | ||
| @api_url = url | ||
| @http_client = Excon.new(self.api_url, omit_default_port: true) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR allowed to set a custom api_url attribute and not use the default one. But it wasn't possible to override this attribute multiple times during execution.
That's what this PR does.