Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatten nested plugin config items #27

Merged
merged 1 commit into from
Sep 7, 2018
Merged

flatten nested plugin config items #27

merged 1 commit into from
Sep 7, 2018

Conversation

amireh
Copy link
Contributor

@amireh amireh commented Jul 18, 2018

this builds upon PR #12 in that it extends the support to also cover
plugin configuration that is deeply nested:

config = {
  a = {
    b = 1,
    c = 2
  }
}

# => {
#      "config.a.b" => 1,
#      "config.a.c" => 2
#    }

@amireh
flatten nested plugin config items
4e54a1c 
this builds upon PR kontena#12 in that it extends the support to also cover
plugin configuration that is deeply nested:

    config = {
      a = {
        b = 1,
        c = 2
      }
    }

    # => {
    #      "config.a.b" => 1,
    #      "config.a.c" => 2
    #    }
@kke kke requested a review from nevalla July 23, 2018 06:17
@amireh
Copy link
Contributor Author

amireh commented Jul 23, 2018

Oh and thanks for the library! 😀

nevalla
nevalla approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for contributing.

@nevalla nevalla merged commit 7ae8f3a into kontena:master Sep 7, 2018
nevalla added a commit that referenced this pull request Sep 7, 2018
@nevalla
Fix tests after #27 and #28
5fd9bba
nevalla added a commit that referenced this pull request Sep 7, 2018
@nevalla
Fix tests after #27 and #28 (#30)
391af90 
* Fix tests after #27 and #28

* Update rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

@kke kke kke approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amireh @kke @nevalla