Fix Client#get_resources for custom resources that are not yet defined #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 13, 2018 11:21
|
Note that the This fix relies on the |
|
The behavior of the fixed resources.map{|resource|
begin
client.get_resource(resource)
rescue K8s::Error::NotFound
nil
end
}This is because the same Without this fix, |
SpComb
commented
Aug 13, 2018
| # Hash{arg => value} | ||
| value_map = Hash[func_args.zip(values)] | ||
|
|
||
| args.map{|arg| value_map[arg] } |
There was a problem hiding this comment.
Because of how the hash is used, any duplicate args will map to the same return value... shouldn't be a problem when used with idempotent methods like GET requests, but it's a limitation.
jakolehm
reviewed
Aug 13, 2018
lib/k8s/client.rb
Outdated
| responses = @transport.requests(*requests, skip_missing: true) | ||
|
|
||
| # map non-nil requests to response objects, or nil for nil request options | ||
| Util.compact_map(requests) { |requests| |
There was a problem hiding this comment.
This is shadowing outer local variable .. usually bad practice.
|
Tested to (still) fix kontena/pharos-cluster#523 with git 6d2f7ae... note the initial pipelined 404 -> the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Client#get_resourcesusesapis(prefetch_resources: true, skip_missing: true)to handleGET /apis/certmanager.k8s.io/v1alpha1 => HTTP 404error cases from the prefetched api_resources and skip theGETrequests for those undefined custom resources. Resources that are not yet defined cannot yet exist, so it's valid to returnnilfor those undefined resources.There's some complexity around the new
Util.compact_mapimplementation becauseget_resourcesmust return an array matching theresourcesargument while also skipping over some requests, but this should all have complete spec coverage.