-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devcontainer Tweaks for Running Locally #848
Devcontainer Tweaks for Running Locally #848
Conversation
a74ae49
to
e23482b
Compare
…l browser when running in a devcontainer
e23482b
to
10b15e6
Compare
@ikegentz thanks for this PR. @mrsimonemms is the only one using Devcontainer so I'll let him review this (he already did). Note that he is on vacation starting today, so the final approval may not be until January. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of things to address
529a193
to
3aa88bb
Compare
Thanks for the quick review. You're correct, the I included the |
No worries thanks for the quick review. I think this is all set to go whenever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrsimonemms I'm approving since you are on vacation. Feel free to update anything once you're back.
Thanks @ikegentz 🎉
Description
Was opening the docs for the first time the other day (had never worked in this repo before so have a "vanilla, clean" install). Was not able to access the docs in my browser when using the devcontainer. This is a two-fold issue:
localhost
. In this case,0.0.0.0
(any host) makes sense since the development server will only ever used locally, may as well listen on any address the devcontainer may be givenRelated Issue(s)
No related issue, this is just something I noticed when working on something else and figured it may as well get fixed
Fixes #
How to test
Open the devcontainer on the
main
branch, you can't get tolocalhost:3000/docs
. Now checkout this branch, and reopen the devcontainer, it will now be accessible