Fix native file descriptor being closed while still exporting. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ParcelFileDescriptor gets garbage collected that will close the associated file descriptor. Since the exporting happens async in a different block, we can end up trying to write to a closed file descriptor. To fix this, just pass the ParcelFileDescriptor to the object doing the async export, so it will be destroyed only after we have closed the stream we write to. Fixes issue konradrenner#188.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ParcelFileDescriptor gets garbage collected that will
close the associated file descriptor.
Since the exporting happens async in a different block, we can
end up trying to write to a closed file descriptor.
To fix this, just pass the ParcelFileDescriptor to the object
doing the async export, so it will be destroyed only after we
have closed the stream we write to.
Fixes issue #188.