Expose mute and volume status and fix volume status parsing #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents KeyErrors if is_updated property is accessed before device is initialized.
Renamed _mute_value to _volume_status to be more clear and match the language found at www.cec-o-matic.com and in the spec.
CEC spec at https://github.com/floe/CEC/blob/master/extras/CEC_Specs.pdf says volume status represents 0-100%. I verified this behavior with an audio receiver as well.
|
konikvranik
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get this info surfaced in hdmi_cec-backed home-assistant media-player components.