-
Notifications
You must be signed in to change notification settings - Fork 12
Remote secret rejected data upload metric #179
Remote secret rejected data upload metric #179
Conversation
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good with the nitpick of maybe precreating the differently labeled counters and incrementing. Not sure if that's even worth the trouble though, because it means saving a couple of allocations only in the error cases of which there should be few.
Signed-off-by: Max Shaposhnyk <[email protected]>
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is working for me.
Checked
redhat_appstudio_remotesecret_data_upload_rejected_total{operation="webhook_validate",reason="unique_targets_check_failed"}
redhat_appstudio_remotesecret_data_upload_rejected_total{operation="secret_data_upload",reason="invalid_upload_secret"}
Documentation
Let's think about some documentation before the merge. For example docs/Monitoring.md
Mertric | Description |
---|---|
redhat_appstudio_remotesecret_data_upload_rejected_total{operation="webhook_validate",reason="unique_targets_check_failed"}` | This is ... |
Signed-off-by: Max Shaposhnyk <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshaposhnik, skabashnyuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
PR adds metrics for the failed upload data operations, with the operation name and failure reason labels, so the counterscan be filtered/ordered by them.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/SVPI-575
How to test this PR?
(can use the
remote-secret-conflicting-targets
sample or example below )