Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1124): validate Application reference #560

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

davidmogar
Copy link
Collaborator

This commit adds a new validation function to ensure that the Application referenced in the ReleasePlan and in the Snapshot is the same.

@davidmogar davidmogar requested a review from a team as a code owner September 11, 2024 12:52
johnbieren
johnbieren previously approved these changes Sep 11, 2024
@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2024
Copy link
Collaborator

@happybhati happybhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a rebase!
LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 28, 2024
This commit adds a new validation function to ensure that the
Application referenced in the ReleasePlan and in the Snapshot
is the same.

Signed-off-by: David Moreno García <[email protected]>
Copy link
Collaborator

@happybhati happybhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 29, 2024
@happybhati happybhati merged commit 0f25f5a into main Oct 29, 2024
9 checks passed
@happybhati happybhati deleted the release1124 branch October 29, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants