-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1124): validate Application reference #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
previously approved these changes
Sep 11, 2024
davidmogar
force-pushed
the
release1124
branch
from
October 22, 2024 12:28
6dc0f2c
to
2e8f171
Compare
johnbieren
approved these changes
Oct 22, 2024
happybhati
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a rebase!
LGTM
davidmogar
force-pushed
the
release1124
branch
from
October 28, 2024 12:49
2e8f171
to
3d8aa65
Compare
happybhati
approved these changes
Oct 28, 2024
This commit adds a new validation function to ensure that the Application referenced in the ReleasePlan and in the Snapshot is the same. Signed-off-by: David Moreno García <[email protected]>
davidmogar
force-pushed
the
release1124
branch
from
October 29, 2024 12:45
3d8aa65
to
93973c4
Compare
happybhati
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new validation function to ensure that the Application referenced in the ReleasePlan and in the Snapshot is the same.