Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogMessageTestParsingSuccessfully fails due to unnkown Sys Log #54

Open
dheldt opened this issue May 11, 2021 · 3 comments
Open

LogMessageTestParsingSuccessfully fails due to unnkown Sys Log #54

dheldt opened this issue May 11, 2021 · 3 comments

Comments

@dheldt
Copy link
Collaborator

dheldt commented May 11, 2021

Currently the test LogMessageTestParsingSuccessfully fails,

because the file

Unixt_1607363188_Sig-13_Log-Sys_setConfiguration.log

cannot be identified for some reason, so the LogMessageFactory fails to select what kind of message to create.

@dheldt
Copy link
Collaborator Author

dheldt commented May 11, 2021

I probably created this, by checking in a hardcoded path, that works on my machine, but nowhere else.

This explains, why all tests suceed here on github

@dheldt
Copy link
Collaborator Author

dheldt commented May 11, 2021

With PR #58 I did fix the local path. It does not fix the failing test. To fix that, LogMessageFactory has to be able to parse unknown SystemLogs again.

@nils-tekampe
Copy link
Contributor

Having the test fail is fine for the moment. I will continue working on the system logs soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants