Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups.new working demo driver, lots of docs (not complete) #191

Merged
merged 2 commits into from
Jul 26, 2020

Conversation

mmaney
Copy link
Collaborator

@mmaney mmaney commented Jun 30, 2020

Legacy DNS list changed to unordered (fix pypi display?)
Provider init method interfaces revised - much is hoisted up to ProviderBase.
Added working example of legacy DNS driver that uses new aliasing!

PR for review - there will be at least some doc cleanups yet. Oh, and **kwargs for legacy drivers, cli options...

LOTS of new or revised documentation and design notes in /docs, as well as some notes on a new or much modified sewer-cli, code name cloaca.

Accidentally lost the remote branch, so this is the same PR under a new number, and with some updates for things that spun off and landed in master already.

@menduo I think this finally addresses #154?

@SN9NV does this help with #123?

@aphexer this is as much as I can do for #175 from outside the individual drivers. Want to modify one (and maybe make it the first migrated of our legacy drivers )?

@alanbacon I think this has overkilled #166, aside from needing to add **kwargs and cli option(s).
Or I get confused about which timeout is which delay. This is completely separate, so it's back on the list. :-(

@komuw while playing around with the cloaca design, it occured to me that in that setting #114 might be a more interesting option. You fix some, you re-energize some; bugs will be with us always. :-/

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #191 into master will increase coverage by 0.35%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   87.44%   87.79%   +0.35%     
==========================================
  Files          18       18              
  Lines        1131     1131              
==========================================
+ Hits          989      993       +4     
+ Misses        142      138       -4     
Impacted Files Coverage Δ
sewer/client.py 92.13% <91.66%> (+0.44%) ⬆️
sewer/__version__.py 100.00% <100.00%> (ø)
sewer/auth.py 100.00% <100.00%> (+2.12%) ⬆️
sewer/dns_providers/common.py 95.83% <100.00%> (ø)
sewer/lib.py 100.00% <100.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3515d...9608e89. Read the comment docs.

Legacy DNS list changed to unordered (fix pypi display?)
Provider __init__ method interfaces revised - much is hoisted up to ProviderBase.
Added working example of legacy DNS driver that uses new aliasing!
@mmaney mmaney force-pushed the 0.8 branch 2 times, most recently from 38826b5 to f19e5f3 Compare July 7, 2020 16:47
@mmaney mmaney force-pushed the 0.8 branch 3 times, most recently from 66607c2 to 2c00ce5 Compare July 26, 2020 18:31
…onciled

* __version__ set to PRE-0.8.3, DO NOT RELEASE WITHOUT UPDATING THIS!
* unbound_ssh has been added to cli's provider list and used in anger.  Works!
* --p_opt added; --alias_domain and --prop_delay to go away for 0.8.3 release
* added __main__.py to support  python -m sewer  (still needs too many options)
@mmaney
Copy link
Collaborator Author

mmaney commented Jul 26, 2020

2020-07-26: another step towards 0.8.3, finally. Live test used unbound_ssh and code from 0.8 tree to renew local certificates. Chanced across a data-dependent bug in unbound_ssh implementation, fixed. docs/* reviewed, some parts of README moved to separate files there. Reviewed, revised; repeated. Fixed pylint's obsession - it was right in that it's worth checking and reporting, but I hated the mess it made to check and silence pylint directly, so added the disable annotation.

@mmaney mmaney merged commit a42c30c into komuw:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant