Small cleanups.new working demo driver, lots of docs (not complete) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaney
force-pushed
the
0.8
branch
2 times, most recently
from
9dbb369
to
eb7029d
Compare
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 87.46% 87.80% +0.34%
==========================================
Files 18 18
Lines 1133 1132 -1
==========================================
+ Hits 991 994 +3
+ Misses 142 138 -4
Continue to review full report at Codecov.
|
Legacy DNS list changed to unordered (fix pypi display?) Provider __init__ method interfaces revised - much is hoisted up to ProviderBase. Added working example of legacy DNS driver that uses new aliasing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy DNS list changed to unordered (fix pypi display?)
Provider init method interfaces revised - much is hoisted up to ProviderBase.
Added working example of legacy DNS driver that uses new aliasing!
PR for review - there will be at least some doc cleanups yet. Oh, and **kwargs for legacy drivers, cli options...
LOTS of new or revised documentation and design notes in /docs, as well as some notes on a new or much modified sewer-cli, code name cloaca.
@menduo I think this finally addresses #154?
@SN9NV does this help with #123?
@aphexer this is as much as I can do for #175 from outside the individual drivers. Want to modify one (and maybe make it the first migrated of our legacy drivers )?
@alanbacon I think this has overkilled #166, aside from needing to add **kwargs and cli option(s).
@komuw while playing around with the cloaca design, it occured to me that in that setting #114 might be a more interesting option. You fix some, you re-energize some; bugs will be with us always. :-/