Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Provider model; existing DNS providers to be converted piecem… #178

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

mmaney
Copy link
Collaborator

@mmaney mmaney commented May 23, 2020

…eal.

Never used http_providers and shim removed; use unified interface for http-01.
Began removal of the torturous import of import chains; remainder are deprecated.
Test cases that no longer apply removed; others updated to match changes.

notes

This has, I think, the best of the various lines of work that I now think of as 0.9, which will be a release with more disruptive changes I have tried to keep the changes visible to users of both cli and the Client class to a minimum. The latter have had some unavoidable changes to implement the updated protocol cleanly, though if you're using Client through one of the high level interfaces (cert, renew, or get_certificate which the first two are aliases for) I think you'll find it mostly unchanged. The only change in cli.py, aside from adding two new providers, was the cleanup of logging back in #173.

There may be a few other minor changes or cleanups, and I definitely have some work to do on documentation, especially of what changed here. In preparing this I removed some very long and tedious comments from, especially, the new ProviderBase class which will become docs/provider.md (or some such, since I find that all writing, not excluding code, can be prone to finding its own shape as one gets it down on paper. refactoring is just our cult jargon for revising a draft, after all!).

@mmaney mmaney force-pushed the 0.8 branch 3 times, most recently from ba545ce to ac89a33 Compare May 23, 2020 18:37
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #178 into master will decrease coverage by 0.08%.
The diff coverage is 89.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   86.23%   86.15%   -0.09%     
==========================================
  Files          19       18       -1     
  Lines        1090     1141      +51     
==========================================
+ Hits          940      983      +43     
- Misses        150      158       +8     
Impacted Files Coverage Δ
sewer/auth.py 83.33% <82.97%> (ø)
sewer/dns_providers/powerdns.py 93.33% <85.71%> (ø)
sewer/dns_providers/common.py 96.00% <94.11%> (-4.00%) ⬇️
sewer/client.py 89.16% <94.64%> (-0.17%) ⬇️
sewer/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac1e91...b4c3ea4. Read the comment docs.

@komuw
Copy link
Owner

komuw commented May 30, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

Complexity increasing per file
==============================
- sewer/providers/demo.py  3
- sewer/tests/test_auth.py  3
- sewer/providers/tests/test_demo.py  3
         

Clones removed
==============
+ sewer/tests/test_Client.py  -7
         

See the complete overview on Codacy

@mmaney mmaney force-pushed the 0.8 branch 10 times, most recently from 5ad5fa1 to cad1ed8 Compare June 2, 2020 21:18
…eal.

Never-used http_providers and shim removed; new drivers to go in providers.
Began removal of the torturous import of import chains; remainder are deprecated.
Test cases that no longer apply removed; others updated; quite a few added.
Some documentation added. First draft of demo for unified Provider.  prop_* parameters.
Never-ending: Codacy's complaints, test coverage.
@mmaney mmaney merged commit 45e6221 into komuw:master Jun 5, 2020
@mmaney mmaney deleted the 0.8 branch June 5, 2020 22:06
@mmaney mmaney mentioned this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants