Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one-logger: pass logger as an arg to middlewares #84

Merged
merged 6 commits into from
Jul 7, 2022
Merged

one-logger: pass logger as an arg to middlewares #84

merged 6 commits into from
Jul 7, 2022

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 7, 2022

Pass logger to middleware. This is so that the middlewares can share the same logger as the app.
This way, if the app ever logs an error, even the middleware logs will be flushed.
This makes debugging easier for developers

komuw added 6 commits July 7, 2022 16:40
@komuw
pass logger to middleware. This is so that the middlewares can share …
625f2d0 
…the same logger as the app.

This way, if the app ever logs an error, even the middleware logs will be flushed.
This makes debugging easier for developers
@komuw
f
a2f8b07
@komuw
f
825ec1c
@komuw
f
89532fd
@komuw
x
28af620
@komuw
rm server.extendedHandler which is no longer needed
347375a
@komuw komuw merged commit 7e50f5c into main Jul 7, 2022
@komuw komuw deleted the one-logger branch July 7, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@komuw