Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/65: resuse address/port for pprof and redirect servers #67

Merged
merged 8 commits into from
Jun 30, 2022
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 30, 2022

fixes: #65

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #67 (26c2259) into main (a7ec7f7) will decrease coverage by 1.04%.
The diff coverage is 28.35%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   70.91%   69.86%   -1.05%     
==========================================
  Files          20       20              
  Lines        1530     1573      +43     
==========================================
+ Hits         1085     1099      +14     
- Misses        408      435      +27     
- Partials       37       39       +2     
Impacted Files Coverage Δ
server/server.go 35.29% <0.00%> (-4.27%) ⬇️
server/pprof.go 88.70% <82.60%> (-11.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ec7f7...26c2259. Read the comment docs.

@komuw komuw merged commit 93e6c65 into main Jun 30, 2022
@komuw komuw deleted the issues/65 branch June 30, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pprof server and https redirect server do not reuse address/port
2 participants