Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/456: basicAuth; do not show hint #457

Merged
merged 2 commits into from
Jun 16, 2024
Merged

issues/456: basicAuth; do not show hint #457

merged 2 commits into from
Jun 16, 2024

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 16, 2024

  • This was failing in mobile browsers. They were unable to show the username/password popup.
    I suspect that those clients only expect a header of the form www-authenticate: Basic realm=realmStr.
    Where realmStr is a string with no special characters. The docs say that realmStr is any string whose character set is us-ascii. The : colon symbol is part of us-ascii(number 58). So I don't know why it would cause mobile clients to fail.
  • Fixes: basic auth error #456
  • https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/WWW-Authenticate#realm

@komuw komuw merged commit 4a6f1ac into main Jun 16, 2024
4 checks passed
@komuw komuw deleted the issues/456 branch June 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

basic auth error
1 participant