Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/450: mux; detect route conflicts in more cases #453

Merged
merged 27 commits into from
Jun 13, 2024
Merged

issues/450: mux; detect route conflicts in more cases #453

merged 27 commits into from
Jun 13, 2024

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 13, 2024 •
edited
Loading

  • Previously, we were iterating through all the routes that are already part of the router and would break whenever we did not find conflict.
    The correct implementation is to continue instead of breaking the loop.
  • Fixes: mux should raise conflict #450

@komuw komuw changed the title issues/450: mux; detect conflicts in all cases issues/450: mux; detect route conflicts in more cases Jun 13, 2024
@komuw komuw merged commit ba3f7ca into main Jun 13, 2024
4 checks passed
@komuw komuw deleted the issues/450 branch June 13, 2024 11:12
@komuw komuw restored the issues/450 branch June 13, 2024 11:16
@komuw komuw deleted the issues/450 branch July 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mux should raise conflict
1 participant
@komuw