Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/436: Fix a number of CORS issues #442

Merged
merged 53 commits into from
Jun 17, 2024
Merged

issues/436: Fix a number of CORS issues #442

merged 53 commits into from
Jun 17, 2024

Conversation

komuw
Copy link
Owner

@komuw komuw commented May 7, 2024

If allowedOrigins is nil, domain and its www variant are used
Validate allowed origins, methods, headers, etc.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.25000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.46%. Comparing base (94b4f3f) to head (c47532e).
Report is 8 commits behind head on main.

Files Patch % Lines
middleware/cors.go 86.16% 13 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   69.75%   70.46%   +0.70%     
==========================================
  Files          52       54       +2     
  Lines        6137     6352     +215     
==========================================
+ Hits         4281     4476     +195     
- Misses       1541     1551      +10     
- Partials      315      325      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw merged commit 1c1d46e into main Jun 17, 2024
6 checks passed
@komuw komuw deleted the issues/436/cors branch June 17, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ong/cors: Address a few issues
2 participants