Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/414: improve id generation #415

Merged
merged 3 commits into from
Feb 16, 2024
Merged

issues/414: improve id generation #415

merged 3 commits into from
Feb 16, 2024

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 16, 2024

Use a simpler id generation algorithm

benchmark:
old-one  465.3 ns/op	 3 allocs/op
new-one  206.2 ns/op	 2 allocs/op

old-one  465.3 ns/op	 3 allocs/op
new-one  206.2 ns/op	 2 allocs/op
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2fb1649) 69.65% compared to head (25fe250) 69.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   69.65%   69.68%   +0.03%     
==========================================
  Files          52       52              
  Lines        6192     6192              
==========================================
+ Hits         4313     4315       +2     
+ Misses       1556     1555       -1     
+ Partials      323      322       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw merged commit 0415d00 into main Feb 16, 2024
6 checks passed
@komuw komuw deleted the issues/414-id-rand branch February 16, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new id.New()
2 participants