Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync package #387

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Add sync package #387

merged 12 commits into from
Sep 29, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 20, 2023

  • This has a more intuitive Waitgroup.
import "github.com/komuw/ong/sync"

wg, ctx := sync.New(context.Background(), 2)
_ = ctx

err := wg.Go(
    func() error {
        return nil
    },
   )

_ = err

@komuw komuw marked this pull request as ready for review September 29, 2023 10:31
@komuw komuw changed the title Sync.Waitgroup Add sync package Sep 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (cccd396) 73.77% compared to head (71a9e56) 73.70%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   73.77%   73.70%   -0.08%     
==========================================
  Files          48       49       +1     
  Lines        5651     5753     +102     
==========================================
+ Hits         4169     4240      +71     
- Misses       1194     1220      +26     
- Partials      288      293       +5     
Files Coverage Δ
middleware/client_ip.go 100.00% <100.00%> (ø)
middleware/middleware.go 100.00% <100.00%> (ø)
middleware/session.go 65.00% <100.00%> (+0.59%) ⬆️
sess/sess.go 78.87% <100.00%> (+0.61%) ⬆️
internal/clientip/client_ip.go 72.48% <0.00%> (-0.64%) ⬇️
config/config.go 64.74% <68.42%> (+0.16%) ⬆️
middleware/cors.go 92.30% <40.00%> (-2.70%) ⬇️
sync/sync.go 88.40% <88.40%> (ø)
cookie/cookie.go 73.77% <60.97%> (-3.95%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw merged commit 21b7034 into main Sep 29, 2023
3 of 4 checks passed
@komuw komuw deleted the sync branch September 29, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants