Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move middleware.ClientIPstrategy to config.ClientIPstrategy #386

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 15, 2023

No description provided.

@komuw komuw marked this pull request as ready for review September 15, 2023 16:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Patch coverage: 62.06% and project coverage change: -0.21% ⚠️

Comparison is base (cccd396) 73.77% compared to head (c37b586) 73.56%.
Report is 1 commits behind head on main.

❗ Current head c37b586 differs from pull request most recent head 7c061dd. Consider uploading reports for the commit 7c061dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   73.77%   73.56%   -0.21%     
==========================================
  Files          48       48              
  Lines        5651     5671      +20     
==========================================
+ Hits         4169     4172       +3     
- Misses       1194     1206      +12     
- Partials      288      293       +5     
Files Changed Coverage Δ
internal/clientip/client_ip.go 72.48% <0.00%> (-0.64%) ⬇️
middleware/cors.go 92.30% <40.00%> (-2.70%) ⬇️
config/config.go 64.70% <70.00%> (+0.12%) ⬆️
middleware/client_ip.go 100.00% <100.00%> (ø)
middleware/middleware.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw merged commit e2b861f into main Sep 15, 2023
2 of 4 checks passed
@komuw komuw deleted the ip-strategy branch September 15, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants