Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CORS allowCredentials #385

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Add support for CORS allowCredentials #385

merged 2 commits into from
Sep 11, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 11, 2023

No description provided.

@komuw komuw marked this pull request as ready for review September 11, 2023 07:45
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 55.00% and project coverage change: -0.12% ⚠️

Comparison is base (cccd396) 73.77% compared to head (0d299b0) 73.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   73.77%   73.66%   -0.12%     
==========================================
  Files          48       48              
  Lines        5651     5669      +18     
==========================================
+ Hits         4169     4176       +7     
- Misses       1194     1201       +7     
- Partials      288      292       +4     
Files Changed Coverage Δ
middleware/cors.go 92.30% <40.00%> (-2.70%) ⬇️
config/config.go 64.54% <62.50%> (-0.04%) ⬇️
middleware/middleware.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw merged commit 90ee0c3 into main Sep 11, 2023
3 of 4 checks passed
@komuw komuw deleted the cors/credentials branch September 11, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants