Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/366: Serve pprof using the same server as the application #375

Merged
merged 26 commits into from
Sep 1, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 1, 2023

@komuw komuw changed the title Issues/366 pprof same prt issues/366: Serve pprof using the same server as the application Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch coverage: 70.49% and project coverage change: -0.18% ⚠️

Comparison is base (7cbcbb8) 73.45% compared to head (3ebcdea) 73.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   73.45%   73.28%   -0.18%     
==========================================
  Files          46       47       +1     
  Lines        5500     5603     +103     
==========================================
+ Hits         4040     4106      +66     
- Misses       1174     1204      +30     
- Partials      286      293       +7     
Files Changed Coverage Δ
cry/enc.go 74.39% <ø> (ø)
middleware/middleware.go 100.00% <ø> (ø)
server/pprof.go 63.63% <63.63%> (ø)
server/server.go 71.70% <77.35%> (+1.04%) ⬆️
middleware/auth.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw marked this pull request as ready for review September 1, 2023 13:44
@komuw komuw merged commit cd0f168 into main Sep 1, 2023
@komuw komuw deleted the issues/366-pprof-same-prt branch September 1, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pprof server should also be available over https with redirection
2 participants