issues/354: Integrate ong packages with new logger #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
komuw
commented
Aug 14, 2023
•
komuw
commented
- Updates: ong/log: integrate with slog tests #354
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## issues/354-slogtest2 #358 +/- ##
=======================================================
Coverage ? 75.40%
=======================================================
Files ? 44
Lines ? 5107
Branches ? 0
=======================================================
Hits ? 3851
Misses ? 997
Partials ? 259 ☔ View full report in Codecov by Sentry. |
komuw
changed the title
komuw
added a commit
that referenced
this pull request
Aug 14, 2023
komuw
added a commit
that referenced
this pull request
Aug 14, 2023
- Updates: #354 The perfomance for the average case seems to be similar. But for the worst case, it is about 5% slowwer. go test -timeout 7m -count=10 -run=XXXX -bench=BenchmarkAverageCase/ong github.com/komuw/ong/log > old.txt go test -timeout 7m -count=10 -run=XXXX -bench=BenchmarkAverageCase/ong github.com/komuw/ong/log > new.txt benchstat old.txt new.txt pkg: github.com/komuw/ong/log cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ AverageCase/ong-8 4.987µ ± 13% 5.093µ ± 10% ~ (p=0.128 n=10) │ old.txt │ new.txt │ │ B/op │ B/op vs base │ AverageCase/ong-8 1.475Ki ± 0% 1.411Ki ± 0% -4.30% (p=0.000 n=10) │ old.txt │ new.txt │ │ allocs/op │ allocs/op vs base │ AverageCase/ong-8 27.00 ± 0% 25.00 ± 0% -7.41% (p=0.000 n=10) go test -timeout 7m -count=10 -run=XXXX -bench=BenchmarkWorstCase/ong github.com/komuw/ong/log > old.txt go test -timeout 7m -count=10 -run=XXXX -bench=BenchmarkWorstCase/ong github.com/komuw/ong/log > new.txt benchstat old.txt new.txt pkg: github.com/komuw/ong/log cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ WorstCase/ong-8 8.196µ ± 9% 8.643µ ± 9% +5.45% (p=0.023 n=10) │ old.txt │ new.txt │ │ B/op │ B/op vs base │ WorstCase/ong-8 2.063Ki ± 0% 1.938Ki ± 0% -6.11% (p=0.000 n=10) │ old.txt │ new.txt │ │ allocs/op │ allocs/op vs base │ WorstCase/ong-8 42.00 ± 0% 38.00 ± 0% -9.52% (p=0.000 n=10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.