Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/295: Use testing.Testing() where appropriate #351

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Aug 8, 2023

@komuw komuw marked this pull request as ready for review August 8, 2023 16:21
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.10% ⚠️

Comparison is base (7f64d26) 74.95% compared to head (9aa99f0) 74.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   74.95%   74.86%   -0.10%     
==========================================
  Files          43       43              
  Lines        4963     4969       +6     
==========================================
  Hits         3720     3720              
- Misses        994      997       +3     
- Partials      249      252       +3     
Files Changed Coverage Δ
automax/automax.go 50.00% <0.00%> (-50.00%) ⬇️
internal/acme/acme.go 74.48% <33.33%> (-0.60%) ⬇️
internal/acme/helpers.go 65.42% <100.00%> (+0.12%) ⬆️
internal/acme/http_client.go 69.37% <100.00%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw merged commit 6065681 into main Aug 8, 2023
@komuw komuw deleted the issues/295 branch August 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use testing.Testing(); August 15th 2023
2 participants