Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the secretKey has some minimum security properties #329

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 19, 2023

No description provided.

@komuw komuw marked this pull request as ready for review July 19, 2023 06:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.10 ⚠️

Comparison is base (014bf46) 74.92% compared to head (61098ec) 74.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   74.92%   74.83%   -0.10%     
==========================================
  Files          43       44       +1     
  Lines        4897     4935      +38     
==========================================
+ Hits         3669     3693      +24     
- Misses        985      994       +9     
- Partials      243      248       +5     
Impacted Files Coverage Δ
middleware/middleware.go 99.09% <0.00%> (-0.91%) ⬇️
internal/key/key.go 66.66% <66.66%> (ø)
cry/enc.go 74.39% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw force-pushed the check-secretKey branch from db84847 to b69caec Compare July 19, 2023 18:49
@komuw komuw merged commit 14b3bbc into main Jul 19, 2023
@komuw komuw deleted the check-secretKey branch July 19, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants