Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/327: Bugfix, fetch certficate for subdomain beginning with number. #328

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 18, 2023

@komuw komuw marked this pull request as ready for review July 18, 2023 19:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.86 🎉

Comparison is base (38d7414) 74.11% compared to head (4696550) 74.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   74.11%   74.98%   +0.86%     
==========================================
  Files          43       43              
  Lines        4895     4897       +2     
==========================================
+ Hits         3628     3672      +44     
+ Misses       1021      983      -38     
+ Partials      246      242       -4     
Impacted Files Coverage Δ
internal/acme/acme.go 75.07% <84.61%> (+11.90%) ⬆️
middleware/redirect.go 90.21% <100.00%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 2248c3b into main Jul 18, 2023
@komuw komuw deleted the issues/327 branch July 18, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acme: request for certificate for subdomain starting with number is rejected
2 participants