Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme: add context cancellation #314

Merged
merged 11 commits into from
Jul 6, 2023
Merged

acme: add context cancellation #314

merged 11 commits into from
Jul 6, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 6, 2023

No description provided.

@komuw komuw marked this pull request as ready for review July 6, 2023 20:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Patch coverage: 90.47% and project coverage change: +0.04 🎉

Comparison is base (9ddad35) 74.11% compared to head (26f51c6) 74.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   74.11%   74.16%   +0.04%     
==========================================
  Files          43       43              
  Lines        4849     4858       +9     
==========================================
+ Hits         3594     3603       +9     
  Misses       1008     1008              
  Partials      247      247              
Impacted Files Coverage Δ
internal/acme/acme.go 66.77% <82.75%> (+1.97%) ⬆️
internal/acme/client.go 59.75% <96.55%> (ø)
internal/acme/helpers.go 65.29% <100.00%> (-1.12%) ⬇️
internal/acme/http_client.go 69.18% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 3d70cfb into main Jul 6, 2023
@komuw komuw deleted the ctx branch July 6, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants